Automatically start workflow right after create an an entity

Hi Oro Team,

I try to start a custom workflow right after create a call entity. I am using 3.0.0-rc version

The workflow does not perform any action for the moment

YAML

workflows: phone_call: defaults: active: true entity: Oro\Bundle\CallBundle\Entity\Call start_step: start_call steps: start_call: allowed_transitions: - connected - not_answered start_conversation: allowed_transitions: - end_conversation end_call: is_final: true transitions: connected: step_to: start_conversation transition_definition: connected_definition frontend_options: class: 'btn-success' not_answered: step_to: end_call transition_definition: not_answered_definition frontend_options: class: 'btn-warning' end_conversation: step_to: end_call transition_definition: end_conversation_definition frontend_options: class: 'btn-primary' transition_definitions: connected_definition: [] not_answered_definition: [] end_conversation_definition: []

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42

workflows:     phone_call:         defaults:             active: true         entity: Oro\Bundle\CallBundle\Entity\Call         start_step: start_call         steps:             start_call:                 allowed_transitions:                     - connected                     - not_answered             start_conversation:                 allowed_transitions:                     - end_conversation             end_call:                 is_final: true           transitions:             connected:                 step_to: start_conversation                 transition_definition: connected_definition                 frontend_options:                     class: 'btn-success'               not_answered:                 step_to: end_call                 transition_definition: not_answered_definition                 frontend_options:                     class: 'btn-warning'               end_conversation:                 step_to: end_call                 transition_definition: end_conversation_definition                 frontend_options:                     class: 'btn-primary'           transition_definitions:             connected_definition: []               not_answered_definition: []               end_conversation_definition: []

Basically I create a Call entity and try to start workflow right after

PHP

$call = (new Call()) ->setOwner($voip->getDefaultUsers()) ->setSubject($voip->getDefaultSubject()) ->setPhoneNumber($caller) ->setDirection($em->getRepository(CallDirection::class) ->findOneBy(['name' => 'incoming']) ) ->setCallStatus($em->getRepository(CallStatus::class) ->findOneBy(['name' => 'waiting']) ) ->setOrganization($voip->getDefaultUsers()->getOrganization()); $em->persist($call); $em->flush(); $workflowManager->startWorkflow('phone_call', $call);

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16

$call = (new Call())                 ->setOwner($voip->getDefaultUsers())                 ->setSubject($voip->getDefaultSubject())                 ->setPhoneNumber($caller)                 ->setDirection($em->getRepository(CallDirection::class)                     ->findOneBy(['name' => 'incoming'])                 )                 ->setCallStatus($em->getRepository(CallStatus::class)                     ->findOneBy(['name' => 'waiting'])                 )                 ->setOrganization($voip->getDefaultUsers()->getOrganization());               $em->persist($call);             $em->flush();               $workflowManager->startWorkflow('phone_call', $call);

But I got an Exception

Uncaught PHP Exception Oro\Bundle\WorkflowBundle\Exception\WorkflowNotFoundException: "Workflow "phone_call" not found" at /home/sinabs/sites/dev.orocrm.sinabs.fr/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/WorkflowRegistry.php line 74

1 2 3

Uncaught PHP Exception Oro\Bundle\WorkflowBundle\Exception\WorkflowNotFoundException: "Workflow "phone_call" not found" at /home/sinabs/sites/dev.orocrm.sinabs.fr/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/WorkflowRegistry.php line 74

The workflow is correctly loaded and stored in DB, I can start it with the UI.

I don’t understand what is the problem.

Some help will be appreciate.

Thanks

• This topic was modified 5 years, 9 months ago by  adriwan_kenoby.

Topic

[Andrey YatsenkoModerator]

I don’t see any issues at the above code. The faster way for you to know why it’s failed will be debugging at WorkflowRegistry, you can set the breakpoint at line 53.

First – the workflow identifier can be incorrect, or workflow was not loaded to the database or there are some caches. But if you can start it with UI – this should be ok.
Second – some of the filters that implement \Oro\Bundle\WorkflowBundle\Model\Filter\WorkflowDefinitionFilterInterface can remove your workflow from results, but as I see at the configuration you provided – it should not, so probably it failed earlier on loading workflow from the database.

The Task entity already has the very similar workflow, you can use it as an example:
https://github.com/oroinc/OroCRMTaskBundle/tree/master/Resources/config/oro/workflows

About the start from the controller – the code is valid as well. We have a similar start of the workflow at many data fixtures like this one https://github.com/oroinc/orocommerce/blob/master/src/Oro/Bundle/CheckoutBundle/Tests/Functional/DataFixtures/LoadCheckoutACLData.php#L80

[adriwan_kenobyParticipant]

Hi Andrey,

At https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/WorkflowBundle/Model/WorkflowRegistry.php#L69

$definition = $this->processDefinitionFilters(new ArrayCollection([$definition]))->first(); return null value

At the end of this loop Line 214

foreach ($this->definitionFilters->getFilters() as $definitionFilter) { $workflowDefinitions = $definitionFilter->filter($workflowDefinitions); }

1 2 3

foreach ($this->definitionFilters->getFilters() as $definitionFilter) {             $workflowDefinitions = $definitionFilter->filter($workflowDefinitions);         }

The variable $workflowDefinitions is empty.

[adriwan_kenobyParticipant]

Hi Andrey,

Go in deeper I found that :

Their is three definitionFilter
– FeatureCheckerWorkflowRegistryFilter
– WorkflowDefinitionScopesRegistryFilter
– WorkflowDefinitionApplicationsRegistryFilter

I think the problem come from https://github.com/oWorkflowDefinitionApplicationsRegistryFilter

At Line 27 : $currentApplication = $this->currentApplicationProvider->getCurrentApplication();

The $currentApplication is null.

In fact the controller is called from keyyo service and I have this conf:

YAML

security: firewalls: cti: pattern: ^/admin/voip/voip/keyyo-cti$ security: false anonymous: true

1 2 3 4 5 6

security:     firewalls:         cti:             pattern: ^/admin/voip/voip/keyyo-cti$             security: false             anonymous: true

This is for test purpose, i will only allow ip from keyyo after.

The problem is that the call from keyyo to this controller is anonyme then their is no token to identify a user and then the getCurrentApplication() method return always null value.

I don’t want to create an API method because I can’t edit Keyyo script who’s just make a GET request to a specific URL.

Any advice to perform the action without break the security should be appreciate.

[Andrey YatsenkoModerator]

The simpler solution would be to decorate the WorkflowDefinitionApplicationsRegistryFilter to add an exception and don’t filter the phone_call workflow.

[Author]

Replies