OroSecurityBundle: How to override an AbstractAclExtension?

Hi there,

I want to modify (override one method):
—
OroSecurityBundle/Acl/Extension/AbstractAccessLevelAclExtension.php

What I have done:
—

1) have extended OroSecurityBundle with custom MySecurityBundle.

2) have built an extension class:

PHP

?php namespace MySecurityBundle\Acl\Extension; use Oro\Bundle\SecurityBundle\Acl\Extension\AbstractAccessLevelAclExtension; use Oro\Bundle\SecurityBundle\Authentication\Token\OrganizationContextTokenInterface; abstract class MyAbstractAccessLevelAclExtension extends AbstractAccessLevelAclExtension { // some method protected function someOroMethodToOverride() { } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

?php   namespace MySecurityBundle\Acl\Extension;   use Oro\Bundle\SecurityBundle\Acl\Extension\AbstractAccessLevelAclExtension; use Oro\Bundle\SecurityBundle\Authentication\Token\OrganizationContextTokenInterface;   abstract class MyAbstractAccessLevelAclExtension extends AbstractAccessLevelAclExtension {     // some method     protected function someOroMethodToOverride() {          }   }

3) Registerd the extension class as a service:

PHP

# # MySecurityBundle/Resources/config/services.yml # parameters: dergraf_security.acl.extension.my_access_level.class: ... ... MySecurityBundle\Acl\Extension\MyAbstractAccessLevelAclExtension services: dergraf_security.acl.extension.my_access_level: public: false class: '%dergraf_security.acl.extension.my_access_level.class%' tags: - { name: oro_security.acl.extension, priority: 20 } #

1 2 3 4 5 6 7 8 9 10 11 12 13 14

# #   MySecurityBundle/Resources/config/services.yml       # parameters:   dergraf_security.acl.extension.my_access_level.class: ...    ... MySecurityBundle\Acl\Extension\MyAbstractAccessLevelAclExtension    services:   dergraf_security.acl.extension.my_access_level:     public: false     class: '%dergraf_security.acl.extension.my_access_level.class%'     tags:       - { name: oro_security.acl.extension, priority: 20 } #

Obviously I missed some arguments for my service. But extended class does not use any.

Furthermore I am not sure, is this the right way to extend an abstract class?

Thank you for some recommandation in which direction I have to go …!

Kind regards
Frank

Topic

[Andrey YatsenkoModerator]

Hi Frank,

This is probably not the right class to extend and you should go deeper to the voter level as customization fo this extension can break the whole security engine.

But anyway, if you decided to override the class, consider overriding the concrete ACL extensions by defining the service with the same name as the original one, so at the end, you will override all the concrete classes extended from the abstract.

[FrankParticipant]

Hi,

I’d suspected something like that.

However, my thoughts are:

1) It does not make very much sense to solve my problem on voter-level, as I would have to code the very similar functionality once again, which is domiciled in ‘AbstractAccessLevelAclExtension’ already.
My customization is 1 line code only, to be added.

2) Overriding a concrete class which extends ‘AbstractAccessLevelAclExtension’ does not solve my problem, as it does not touch the parent abstract Class (‘AbstractAccessLevelAclExtension’) method, I want to modify.
(Hoping, I understand Andrey’s recommandation correctly).

The only way could be to extend ‘AbstractAccessLevelAclExtension’ itself with a class called ‘AbstractAccessLevelAclExtension2’ for example , and register ‘AbstractAccessLevelAclExtension2’ under the same ‘id’ in service.yml as ‘AbstractAccessLevelAclExtension’ has.

BUT ‘AbstractAccessLevelAclExtension’ is not registered as a service, and does not have a container-definition-id!

I don’t want to modify oro’s core code at all! Furthermore the code of the securityBundle …

Any idea, what I can do?

Thanks a lot
Frank

[Author]

Replies