Bug : On All Payment Method that receives some inputs

Hi There,

I see there is a bug in all the payment method that receives the inputs. Below is the way to replicate the bug

1) Select Any Payment Method that recieves a input example PayPal
2) Enter your card details & click continue. Your will end up in the Order Review Screen
3) Now click back & go to payment screen . Next click continue again. The workflow don’t proceed
4) Keep clicking any number of times.. You go nowhere. That’s the bug

Why This bug is Occurs in the first place
Because we call validate function on “checkout:payment:before-transit”. The validate function return true for the first time. All is well then. When you come back to the payment page & click continue again then validate function return false. Hence user is not transited to Order Review Page.

Which Payment Methods have been affected by this bug
Almost all payment gateway that uses Jquery Validator has been affected by this bug. I personally opened the code of all the payment gateway that OroCommerce has officially documented & found the following payment methods has been affected.

1) PayPal
2) AuthorizeNet
3) Wirecard
4) InfinitePay
5) InfinitePay

Only Apruve Payment Method is not affected by this bug because it doesn’t use any validation on “checkout:payment:before-transit”

• This topic was modified 5 years, 7 months ago by  sachingk.30.
• This topic was modified 5 years, 7 months ago by  sachingk.30.

Topic

[sachingk.30Participant]

Guess I found the technical reason for this bug

JavaScript

appendElement = this.$form.clone(); // Clone Will not copy the values for both inputs & select

1	appendElement = this.$form.clone(); // Clone Will not copy the values for both inputs & select

Hence I change the following code for my payment method as follows

JavaScript

virtualForm.find('input,select').each(function(index, item) { var fieldName = $(item).attr("data-ftid"); $(item).val($('input[data-ftid="'+fieldName+'"]').val()); }); // Some how even the self.$form.find('select').eq(index).val() // was also retuning empty values.

1 2 3 4 5 6 7 8

virtualForm.find('input,select').each(function(index, item) {     var fieldName =  $(item).attr("data-ftid");      $(item).val($('input[data-ftid="'+fieldName+'"]').val()); });     // Some how even the self.$form.find('select').eq(index).val() // was also retuning empty values.

Now some one please confirm my buy report as well as bug fix is technically correct.

• This reply was modified 5 years, 7 months ago by  sachingk.30.

[Hryhorii HrebiniukParticipant]

Thank you for reporting the bug. You are right. jQuery copies the HTML, but not the DOM objects with its state of properties. And to fix it, we need to update values manually in cloned HTML (as you’ve proposed), or set values into attributes of HTML elements before cloning. Either solution should work.

We’ve created the bug ticket for it.

Thanks.

• This reply was modified 5 years, 7 months ago by  Andrey Yatsenko.

[Author]

Replies