Validation constraints not being applied

I have an entity CourseOffering which has a schedule attached (OneToMany of CourseOfferingTime entities). I want to ensure that (a) there is at least one CourseOfferingTime in the collection, and (b) that the start < end on each CourseOfferingTime.

CourseOffering#schedule:

/** * @var CourseOfferingTime[]|Collection * * @ORM\OneToMany( * targetEntity="CourseOfferingTime", * mappedBy="courseOffering", * cascade={"persist"}, * orphanRemoval=true * ) * @ORM\OrderBy({"start" = "ASC"}) * @ConfigField( * defaultValues={ * "dataaudit"={ * "auditable"=true * } * } * ) */ private $schedule;

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

/**      * @var CourseOfferingTime[]|Collection      *      * @ORM\OneToMany(      *     targetEntity="CourseOfferingTime",      *     mappedBy="courseOffering",      *     cascade={"persist"},      *     orphanRemoval=true      * )      * @ORM\OrderBy({"start" = "ASC"})      * @ConfigField(      *      defaultValues={      *          "dataaudit"={      *              "auditable"=true      *          }      *      }      * )      */     private $schedule;

CourseOfferingTime class:

class CourseOfferingTime implements EntityProperty\DatesAwareInterface { use EntityProperty\DatesAwareTrait; /** * @var int * * @ORM\Id * @ORM\Column(type="integer") * @ORM\GeneratedValue */ private $id; /** * @var \DateTime * * @ORM\Column(type="datetime") * @Oro\Versioned * @ConfigField( * defaultValues={ * "dataaudit"={ * "auditable"=true * } * } * ) */ private $start; /** * @var \DateTime * * @ORM\Column(type="datetime") * @Oro\Versioned * @ConfigField( * defaultValues={ * "dataaudit"={ * "auditable"=true * } * } * ) */ private $end; /** * @var CourseOffering * * @ORM\ManyToOne(targetEntity="CourseOffering", inversedBy="groups") * @ORM\JoinColumn(name="course_offering", referencedColumnName="id") * @Oro\Versioned * @ConfigField( * defaultValues={ * "dataaudit"={ * "auditable"=true * } * } * ) */ private $courseOffering; // methods removed }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62

class CourseOfferingTime implements EntityProperty\DatesAwareInterface {     use EntityProperty\DatesAwareTrait;       /**      * @var int      *      * @ORM\Id      * @ORM\Column(type="integer")      * @ORM\GeneratedValue      */     private $id;       /**      * @var \DateTime      *      * @ORM\Column(type="datetime")      * @Oro\Versioned      * @ConfigField(      *      defaultValues={      *          "dataaudit"={      *              "auditable"=true      *          }      *      }      * )      */     private $start;       /**      * @var \DateTime      *      * @ORM\Column(type="datetime")      * @Oro\Versioned      * @ConfigField(      *      defaultValues={      *          "dataaudit"={      *              "auditable"=true      *          }      *      }      * )      */     private $end;       /**      * @var CourseOffering      *      * @ORM\ManyToOne(targetEntity="CourseOffering", inversedBy="groups")      * @ORM\JoinColumn(name="course_offering", referencedColumnName="id")      * @Oro\Versioned      * @ConfigField(      *      defaultValues={      *          "dataaudit"={      *              "auditable"=true      *          }      *      }      * )      */     private $courseOffering;       // methods removed   }

CourseOfferingType::buildForm contents:

$builder->add('schedule', 'oro_collection', [ 'label' => 'my.course.courseoffering.entity.schedule.label', 'type' => 'my_course_offering_schedule_entry', 'required' => true, ]);

1 2 3 4 5

$builder->add('schedule', 'oro_collection', [             'label'     => 'my.course.courseoffering.entity.schedule.label',             'type'      => 'my_course_offering_schedule_entry',             'required'  => true,         ]);

CourseOfferingScheduleEntryType::buildForm contents:

$builder->add( 'start', 'oro_datetime', array( 'label' => 'my.course.courseoffering.schedule_entry.entity.start.label', 'required' => true, 'attr' => ['class' => 'start'], ) ); $builder->add( 'end', 'oro_datetime', array( 'label' => 'my.course.courseoffering.schedule_entry.entity.end.label', 'required' => true, 'attr' => ['class' => 'end'], ) );

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18

$builder->add(             'start',             'oro_datetime',             array(                 'label' => 'my.course.courseoffering.schedule_entry.entity.start.label',                 'required' => true,                 'attr'     => ['class' => 'start'],             )         );         $builder->add(             'end',             'oro_datetime',             array(                 'label' => 'my.course.courseoffering.schedule_entry.entity.end.label',                 'required' => true,                 'attr'     => ['class' => 'end'],             )         );

validation.yml:

My\Bundle\CourseBundle\Entity\CourseOffering: properties: schedule: - Required: - Count: min: 1 minMessage: 'You must specify at least one schedule entry' My\Bundle\CourseBundle\Entity\CourseOfferingTime: properties: start: - Required: - NotBlank: ~ - DateTime: ~ - Oro\Bundle\CalendarBundle\Validator\Constraints\DateEarlierThan: end end: - Required: - NotBlank: ~ - DateTime: ~

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

My\Bundle\CourseBundle\Entity\CourseOffering:   properties:     schedule:       - Required:         - Count:             min: 1             minMessage: 'You must specify at least one schedule entry'   My\Bundle\CourseBundle\Entity\CourseOfferingTime:   properties:     start:       - Required:         - NotBlank:     ~         - DateTime:     ~         - Oro\Bundle\CalendarBundle\Validator\Constraints\DateEarlierThan: end     end:       - Required:         - NotBlank:     ~         - DateTime:     ~

But none of the constraints are enforced on the client side or on the server side. (eg: if I add an empty CourseOfferingTime to the form I get a DB constraint violation because start is null, whereas I expect to get a form validation error).

Any thoughts or advice on what I’ve missed in setting up the validation?

Topic

[Mike KudelyaParticipant]

Hi,

I think “- Required” option is not necessary. Try to remove it.

[adamlundriganParticipant]

I’ve tried this as well:

My\Bundle\CourseBundle\Entity\CourseOfferingTime: properties: start: - NotBlank: message: You must specify a start date/time - DateTime: ~ - Oro\Bundle\CalendarBundle\Validator\Constraints\DateEarlierThan: end end: - NotBlank: message: You must specify an end date/time - DateTime: ~

1 2 3 4 5 6 7 8 9 10 11

My\Bundle\CourseBundle\Entity\CourseOfferingTime:   properties:     start:       - NotBlank:           message: You must specify a start date/time       - DateTime:     ~       - Oro\Bundle\CalendarBundle\Validator\Constraints\DateEarlierThan: end     end:       - NotBlank:           message: You must specify an end date/time       - DateTime:     ~

Same result. Inspecting the Javascript, the start and end field of each element of the collection have this in the “data-validation” attribute:

{"Date":[],"NotBlank":[]}

1	{"Date":[],"NotBlank":[]}

I have another entity with custom validation (validation rules defined in same file, but form is rendered on a different page) and this is what I see when I inspect that field:

{"NotBlank":{"message":"This value should not be blank.","payload":null}}

1	{"NotBlank":{"message":"This value should not be blank.","payload":null}}

No idea if that’s even relevant.

[Mike KudelyaParticipant]

Hi,

Be sure that:

• you clear cache after you make yml changes
• you are adding four spaces inside each nested yml level
• you have red * after field label
• you have datetime input field in span element (it is located just above the main element) with all validation data

[adamlundriganParticipant]

The validations are being loaded, the fields are labelled with the red star, and the span element for datetime inputs does have the validation rules enumerated there:

I think it’s a case of the validation not being applied inside the collection. I added a text field and gave it a NotEmpty validator. When I remove the empty row from the collection and try to submit I see this:

but if I add an empty row to the Schedule collection and submit again I don’t get validation errors on the fields:

[Mike KudelyaParticipant]

One question, why are you using inversedBy=”groups” instead inversedBy=”schedule”? As i can see variable named ‘schedule’..

[adamlundriganParticipant]

Copy-and-paste error, probably. Thanks for catching that for me ;)

[Mike KudelyaParticipant]

Perhaps i found one solution, add this function to your general CourseOfferingType form. This allows the main form to validate all child.

PHP

/** * {@inheritdoc} */ public function setDefaultOptions(OptionsResolverInterface $resolver) { $resolver->setDefaults( [ 'data_class' => '[your path to course entity]', 'cascade_validation' => true ] ); }

1 2 3 4 5 6 7 8 9 10 11 12

/**      * {@inheritdoc}      */     public function setDefaultOptions(OptionsResolverInterface $resolver)     {         $resolver->setDefaults(             [                 'data_class'        => '[your path to course entity]',                 'cascade_validation'   => true             ]         );     }

[adamlundriganParticipant]

Argh! I knew it would be something simple I was missing. Thanks!

[vodvudParticipant]

Hi!
I have similar problem.
But I can’t do to require always.

Entity Building

PHP

/** * @var BuildingEstate * * @ORM\OneToMany( * targetEntity="ReBundle\Entity\BuildingEstate", * mappedBy="building", * cascade={"persist"} * ) */ private $estate;

1 2 3 4 5 6 7 8 9 10

/**      * @var BuildingEstate      *      * @ORM\OneToMany(      *     targetEntity="ReBundle\Entity\BuildingEstate",      *     mappedBy="building",      *     cascade={"persist"}      * )      */     private $estate;

Entity BuildingEstate

PHP

/** * @var Building * * @ORM\ManyToOne( * targetEntity="ReBundle\Entity\Building", * inversedBy="estate" * ) * @ORM\JoinColumn( * name="building_id", * referencedColumnName="id", * onDelete="CASCADE" * ) */ private $building;

1 2 3 4 5 6 7 8 9 10 11 12 13 14

/**      * @var Building      *      * @ORM\ManyToOne(      *     targetEntity="ReBundle\Entity\Building",      *     inversedBy="estate"      * )      * @ORM\JoinColumn(      *     name="building_id",      *     referencedColumnName="id",      *     onDelete="CASCADE"      * )      */     private $building;

Form type BuildingType

PHP

$builder->add('estate', 'oro_collection', [ 'required' => true, 'label' => false, 'entry_type' => 'biz_re_building_estate', 'allow_add' => true, 'allow_delete' => true, 'attr' => ['class' => 'biz-re-building-estate-widget'], 'options' => ['data_class' => 'ReBundle\Entity\BuildingEstate'], 'prototype_name' => $this->createPrototypeName(self::class . '_estate'), 'cascade_validation' => true ]);

1 2 3 4 5 6 7 8 9 10 11

$builder->add('estate', 'oro_collection', [         'required' => true,         'label' => false,         'entry_type' => 'biz_re_building_estate',         'allow_add' => true,         'allow_delete' => true,         'attr' => ['class' => 'biz-re-building-estate-widget'],         'options' => ['data_class' => 'ReBundle\Entity\BuildingEstate'],         'prototype_name' => $this->createPrototypeName(self::class . '_estate'),         'cascade_validation' => true     ]);

Form type BuildingEstateType

PHP

$builder ->add('name', CoreType\TextType::class, [ 'required' => true, ]) ->add('description', CoreType\TextareaType::class, [ 'required' => false ]);

1 2 3 4 5 6 7

$builder         ->add('name', CoreType\TextType::class, [             'required' => true,         ])         ->add('description', CoreType\TextareaType::class, [             'required' => false         ]);

Resources/config/validation.yml

YAML

ReBundle\Entity\Building: properties: name: - NotBlank: ~ - Length: max: 255 developer: - NotBlank: ~ subArea: - NotBlank: ~ address: - NotBlank: ~ constructionYear: - NotBlank: ~ - Length: max: 4 ReBundle\Entity\BuildingEstate: properties: name: - NotBlank: ~ - Length: max: 255

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

ReBundle\Entity\Building:     properties:         name:             - NotBlank: ~             - Length:                   max: 255         developer:             - NotBlank: ~         subArea:             - NotBlank: ~         address:             - NotBlank: ~         constructionYear:             - NotBlank: ~             - Length:                 max: 4   ReBundle\Entity\BuildingEstate:     properties:         name:             - NotBlank: ~             - Length:                   max: 255

if collection is empty, i don’t see * near ‘name’ and field doesn’t validate

it is work only if I put some text to any fields

No idea for fix.

[Mike KudelyaParticipant]

Hi

Try to move

PHP

'cascade_validation' => true

1	'cascade_validation' => true

from estate field to setDefaultOptions function how i described above.

[vodvudParticipant]

Yes, I tried that. But it also doesn’t work.

[Mike KudelyaParticipant]

Can you tell me, which version of orocrm are you using ? I will try your case and answer a little later.

[vodvudParticipant]

Version 1.10.12

Validation is works only after submit form, but I see like this one.

It is not critical problem, but working incorrectly for me.

[Mike KudelyaParticipant]

Hi

I found workaround. This is not bug, by default works validation for optional group feature, but for now it can disabled only after some coding.

You can leave the code as is and add opportunity to disable feature:

Add here:

XHTML

{% set data_validation_optional_group = widget.vars.data_validation_optional_group %}

1	{% set data_validation_optional_group = widget.vars.data_validation_optional_group %}

Add here:

XHTML

{% set data_validation_optional_group = widget.parent.vars.data_validation_optional_group %}

1	{% set data_validation_optional_group = widget.parent.vars.data_validation_optional_group %}

Replace this line:

XHTML

{% if data_validation_optional_group %} data-validation-optional-group {% endif %}

1 2 3

{% if data_validation_optional_group %}             data-validation-optional-group         {% endif %}

Add here:

PHP

'data_validation_optional_group' => $options['data_validation_optional_group'],

1	'data_validation_optional_group' => $options['data_validation_optional_group'],

Add here:

PHP

'data_validation_optional_group' => true,

1	'data_validation_optional_group' => true,

By default feature behavior remains the same, but if you add this option to your collection field, validation automatically works as you expected.

PHP

'data_validation_optional_group' => false,

1	'data_validation_optional_group' => false,

[vodvudParticipant]

Hi!

Thank you very much for detailed reply.
But I think it’s a bad idea to edit a platform on my part, because in the future I will not be able to update the platform.

[Author]

Replies