OroCommerce Forums

Covering OroCommerce topics, including community updates and company announcements.

Forums OroCommerce Bug : On All Payment Method that receives some inputs

This topic contains 2 replies, has 2 voices, and was last updated by Hryhorii Hrebiniuk Hryhorii Hrebiniuk 1 year, 1 month ago.

  • Creator
    Topic
  • #37328

    sachingk.30
    Participant

    Hi There,

    I see there is a bug in all the payment method that receives the inputs. Below is the way to replicate the bug

      1) Select Any Payment Method that recieves a input example PayPal
      2) Enter your card details & click continue. Your will end up in the Order Review Screen
      3) Now click back & go to payment screen . Next click continue again. The workflow don’t proceed
      4) Keep clicking any number of times.. You go nowhere. That’s the bug

    Why This bug is Occurs in the first place
    Because we call validate function on “checkout:payment:before-transit”. The validate function return true for the first time. All is well then. When you come back to the payment page & click continue again then validate function return false. Hence user is not transited to Order Review Page.

    Which Payment Methods have been affected by this bug
    Almost all payment gateway that uses Jquery Validator has been affected by this bug. I personally opened the code of all the payment gateway that OroCommerce has officially documented & found the following payment methods has been affected.

      1) PayPal
      2) AuthorizeNet
      3) Wirecard
      4) InfinitePay
      5) InfinitePay

    Only Apruve Payment Method is not affected by this bug because it doesn’t use any validation on “checkout:payment:before-transit”

    • This topic was modified 1 year, 2 months ago by  sachingk.30.
    • This topic was modified 1 year, 2 months ago by  sachingk.30.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Author
    Replies
  • #37331

    sachingk.30
    Participant

    Guess I found the technical reason for this bug

    Hence I change the following code for my payment method as follows

    Now some one please confirm my buy report as well as bug fix is technically correct.

    • This reply was modified 1 year, 2 months ago by  sachingk.30.
    #37349
    Hryhorii Hrebiniuk
    Hryhorii Hrebiniuk
    Participant

    Thank you for reporting the bug. You are right. jQuery copies the HTML, but not the DOM objects with its state of properties. And to fix it, we need to update values manually in cloned HTML (as you’ve proposed), or set values into attributes of HTML elements before cloning. Either solution should work.

    We’ve created the bug ticket for it.

    Thanks.

Viewing 2 replies - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.

You will be redirected to [title]. Would you like to continue?

Yes No