OroCommerce Forums

Covering OroCommerce topics, including community updates and company announcements.

Forums OroCommerce PWA / A2H manifest.json issue not being 'd in

This topic contains 3 replies, has 2 voices, and was last updated by  chris 1 month, 1 week ago.

  • Creator
    Topic
  • #39035

    chris
    Participant

    Following the guide at (https://oroinc.com/b2b-ecommerce/doc/current/dev-guide/other/storefront-customization/replace-the-logo) .. I’ve properly created the App, Bundle and Theme and can see my logo changes correctly as well as my favicons.. In the source, however, I do not see the manifest.json being <link>’d at all?
    I’ve properly defined the path for all of the iconography within a favicon.yml layout update and have created a manifest.json in the same location as my favicons.. However, I never see the manifest.json getting <link>’d on the front end, although all of the changed apple-touch/android-chrome/mstile icon urls properly show and are correct.

    Does the manifest.json need to be defined or included elsewhere? I’m using the CustomThemeBundle as a base. Grepping the oro codebase, I never see the id favicon_manifest anywhere else to match against the option?

    This is from my favicon.yml:

    – ‘@setOption’:
    id: favicon_manifest
    optionName: href
    optionValue: ‘=data[“asset”].getUrl(“bundles/app/default/favicons/manifest.json”)’

Viewing 3 replies - 1 through 3 (of 3 total)
  • Author
    Replies
  • #39036

    chris
    Participant

    That is not from my favicon.yml but rather the default.. my version has the same directory structure as all of the favicons that are being properly linked in the html head .. For instance:

    and in the storefront source I see the correct path to the favicon but no mention of the manifest.json ..

    #39039
    Michael
    Michael
    Keymaster

    Hi Chris,

    We used to have the link to the manifest file added in the default storefront theme.
    Most custom theme developers though did not create the actual manifest file, which caused unnecessary 404 during page load, so we decide to remove these layout instructions from the default theme.

    You can see what exactly was removed in this commit – https://github.com/oroinc/customer-portal/commit/02abbdc1d9716bb398a11e3ce9befc26dd8877bf and implement something similar in your custom theme.

    #39106

    chris
    Participant

    Thank you very much Michael, I was able to modify the default storefront theme view’s favicon.yml and replace the modifications. I immediately saw the manifest properly linked in the html head! As such, I was then able to successfully perform the Add To Home Screen and make the shortcut behave like a PWA properly on Chrome/Android and Firefox/Android immediately! Firefox actually immediately prompts you to add it! It’s great, thank you very much! Chrome’s heuristic is a little bizarre and I’ve yet to see the Add to Home prompt show up yet.. It’s mentioned here and seems to be evolving.
    google specs that have changed
    some other changes

    I do however, notice that the Chrome/iOS, Firefox/IOS and Safari/iOS do not seem to be behaving properly, I’ve got the proper safari-pinned-tab.svg and it’s in the head as well… Possibly a delayed rollout on pinning to home.. =\

    The mstile seems to be hinging on browserconfig.xml which I’m attempting to implement…

    One question for all though, should I be seeing service worker validation on pwabuilder.com ? Can someone run this against their install to see if it gets 100% ? I get 40/40 0/40 and 20/20 ..
    screenshot here of pwabuilder.com

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.

You will be redirected to [title]. Would you like to continue?

Yes No