Language download error

Hi,

I tried to download latest language data via “Language settings”, but French and Japanese are failed (German is OK).
So I investigated why this error happened. The answer is “OroCRMMagentoContactUsBundle/translations/messages.ja_JP.yml” and “OroCRMMagentoContactUsBundle/translations/messages.fr_FR.yml” have wrong YAML expression “* Required Fields:”.

\Symfony\Component\Yaml\Inline::evaluateScalar has this code.

if (0 === strpos($scalar, '*')) { if (false !== $pos = strpos($scalar, '#')) { $value = substr($scalar, 1, $pos - 2); } else { $value = substr($scalar, 1); } if (!array_key_exists($value, $references)) { throw new ParseException(sprintf('Reference "%s" does not exist.', $value)); } return $references[$value]; }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

if (0 === strpos($scalar, '*')) {             if (false !== $pos = strpos($scalar, '#')) {                 $value = substr($scalar, 1, $pos - 2);             } else {                 $value = substr($scalar, 1);             }               if (!array_key_exists($value, $references)) {                 throw new ParseException(sprintf('Reference "%s" does not exist.', $value));             }               return $references[$value];         }

This code search where “*” character is in $scalar and if it is found first position, it’s removed.
So I think, the right way is,

remove “*” from this keyword.
change this keyword.

Thanks,

Topic

[ishakutaParticipant]

Hi,
thank you for reporting an issue, it came with recent symfony component update and now, as you describe, * sign used for referencing (according to YAML standard).
We’ll fix this issue in next release and nightly builds.

[Author]

Replies